Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation Library

[Yazen Ghannam]

On 8/8/2023 8:10 AM, Borislav Petkov wrote:
> On August 8, 2023 5:17:33 AM GMT+02:00, "Limonciello, Mario" <mario.limonciello@xxxxxxx> wrote:
> > Given it's 'library code' to be used by a bunch of things and also want to be able to use a module, what about putting it in lib/?  There's plenty of library code there as tristate.
>
> It is x86-specific so not in there. Also, it might be used by multiple things so you want it as a separate "translation" service which is called by other modules.

There are modules in arch/x86, so I guess that's not an issue (not sure 
what I was thinking).

This code is AMD-specific, and there's vendor-specific code in arch/x86 
already. So it may be fine to have this in arch/x86/ras.

But just because there's existing vendor-specific code in arch/x86 
doesn't necessarily mean we should keep adding to it. So is this okay?

Thanks,
Yazen