Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation Library

From: Borislav Petkov
Date: Tue Aug 08 2023 - 15:22:44 EST


On Tue, Aug 08, 2023 at 10:07:19AM -0400, Yazen Ghannam wrote:
> But just because there's existing vendor-specific code in arch/x86 doesn't
> necessarily mean we should keep adding to it. So is this okay?

I'd say since it is not so close to the arch/ part, drivers/ras/ is more
fitting IMO. Just like mce_amd is in drivers/edac/.

Which reminds me: why aren't you adding it to

drivers/edac/mce_amd.c

?

That is an MCE decoder *already*.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette