Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation Library

From: Yazen Ghannam
Date: Tue Aug 08 2023 - 12:23:40 EST


On 8/8/2023 10:20 AM, Borislav Petkov wrote:
On Tue, Aug 08, 2023 at 10:07:19AM -0400, Yazen Ghannam wrote:
But just because there's existing vendor-specific code in arch/x86 doesn't
necessarily mean we should keep adding to it. So is this okay?

I'd say since it is not so close to the arch/ part, drivers/ras/ is more
fitting IMO. Just like mce_amd is in drivers/edac/.


Okay, then I'll move this set to drivers/ras, if there are no objections from others.

Which reminds me: why aren't you adding it to

drivers/edac/mce_amd.c

?

That is an MCE decoder *already*.


Because this isn't intended to be only for MCA errors. The translation code is related to the AMD Data Fabric. And it'll be a common back-end for memory errors coming from MCA and CXL.

Thanks,
Yazen