Re: [PATCH v3 2/2] iio: adc: mcp3911: add support for the whole MCP39xx family

[Andy Shevchenko]

On Tue, Aug 08, 2023 at 09:49:43AM +0200, Krzysztof Kozlowski wrote:
> On 08/08/2023 09:22, Marcus Folkesson wrote:

...

> >>> +	ret = device_property_read_u32(&adc->spi->dev, "microchip,device-addr", &adc->dev_addr);
> >>
> >> Why not spi->dev? Ditto for other uses like this.
> > 
> > After all, I think it is better to stick sith adc->spi-dev to be
> > consistent with the rest of the probe function. Change to spi->dev
> > should probably be a seperate patch.
> > Do you agree?
> > 
> 
> You can first simplify the usages and then add new family support
> already using spi->dev.

He-he, answered the same :-)

-- 
With Best Regards,
Andy Shevchenko