Re: [PATCH v5 03/24] x86/resctrl: Create helper for RMID allocation and mondata dir creation

From: Reinette Chatre
Date: Wed Aug 09 2023 - 18:33:06 EST


Hi James,

On 7/28/2023 9:42 AM, James Morse wrote:
> When monitoring is support, each monitor and control group is allocated

"When monitoring is support" -> "When monitoring is supported"

> an RMID. For control groups, rdtgroup_mkdir_ctrl_mon() later goes on to
> allocate the CLOSID.
>
> MPAM's equivalent of RMID are not an independent number, so can't be
> allocated until the CLOSID is known. An RMID allocation for one CLOSID
> may fail, whereas another may succeed depending on how many monitor
> groups a control group has.
>
> The RMID allocation needs to move to be after the CLOSID has been
> allocated.
>
> Move the RMID allocation and mondata dir creation to a helper, this
> makes a subsequent change easier to read.

Reinette