Re: [PATCH v2] media: vcodec: Fix potential array out-of-bounds in encoder queue_setup

From: Chen-Yu Tsai
Date: Thu Aug 10 2023 - 04:32:17 EST


On Thu, Aug 10, 2023 at 4:23 PM Wei Chen <harperchen1110@xxxxxxxxx> wrote:
>
> variable *nplanes is provided by user via system call argument. The
> possible value of q_data->fmt->num_planes is 1-3, while the value
> of *nplanes can be 1-8. The array access by index i can cause array
> out-of-bounds.
>
> Fix this bug by checking *nplanes against the array size.
>
> Fixes: 4e855a6efa54 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver")
> Signed-off-by: Wei Chen <harperchen1110@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>