Re: [PATCH v2 04/12] iommu: Replace device fault handler with iommu_queue_iopf()

[Baolu Lu]

On 2023/8/11 2:22, Jason Gunthorpe wrote:
> On Thu, Jul 27, 2023 at 01:48:29PM +0800, Lu Baolu wrote:
> > The individual iommu drivers report iommu faults by calling
> > iommu_report_device_fault(), where a pre-registered device fault handler
> > is called to route the fault to another fault handler installed on the
> > corresponding iommu domain.
> >
> > The pre-registered device fault handler is static and won't be dynamic
> > as the fault handler is eventually per iommu domain. Replace calling
> > device fault handler with iommu_queue_iopf().
> >
> > Signed-off-by: Lu Baolu<baolu.lu@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/iommu/iommu.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index 4352a149a935..00309f66153b 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -1381,7 +1381,7 @@ int iommu_report_device_fault(struct device *dev, struct iommu_fault_event *evt)
> >   		mutex_unlock(&fparam->lock);
> >   	}
> >   
> > -	ret = fparam->handler(&evt->fault, fparam->data);
> > +	ret = iommu_queue_iopf(&evt->fault, dev);
> >   	if (ret && evt_pending) {
> >   		mutex_lock(&fparam->lock);
> >   		list_del(&evt_pending->list);
> I don't get it, why not remove fparam->handler/data entirely in this
> patch? There is no user once you do this change?

It needs some cleanups elsewhere, so I put it in a separate patch.

Best regards,
baolu