Re: [RFC][PATCH 07/17] x86/cpu/kvm: Provide UNTRAIN_RET_VM

From: Peter Zijlstra
Date: Mon Aug 14 2023 - 06:36:54 EST


On Sun, Aug 13, 2023 at 12:36:57PM +0200, Borislav Petkov wrote:
> On Wed, Aug 09, 2023 at 09:12:25AM +0200, Peter Zijlstra wrote:
> > With the difference being that UNTRAIN_RET_VM uses
> > X86_FEATURE_IBPB_ON_VMEXIT instead of X86_FEATURE_ENTRY_IBPB.
> >
> > This cures VMEXIT doing potentially unret+IBPB or double IBPB.
>
> Can't - I have a separate flag for that and I set it only when !IBPB:
>
> case SRSO_CMD_IBPB_ON_VMEXIT:
> if (IS_ENABLED(CONFIG_CPU_SRSO)) {
> if (!boot_cpu_has(X86_FEATURE_ENTRY_IBPB) && has_microcode) {
> setup_force_cpu_cap(X86_FEATURE_IBPB_ON_VMEXIT);
>

Of course you can, just also set it with regular IBPB :-)