Re: [PATCH v10 2/2] Input: Add Novatek NT36xxx touchscreen driver

From: Joel Selvaraj
Date: Tue Aug 15 2023 - 21:10:10 EST


Hi Konrad Dybcio,

On 8/8/23 18:38, Konrad Dybcio wrote:
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

This is a driver for the Novatek in-cell touch controller and
supports various chips from the NT36xxx family, currently
including NT36525, NT36672A, NT36676F, NT36772 and NT36870.

In kernel v6.4, a basic novatek touchscreen driver was introduced [1].
I was able to tweak IT a bit (add devicetree compatible, regulator support, remove chip id hardcode) and get it properly working in my Xiaomi Poco F1 which has Novatek NT36672A touchscreen. Probably the other ICs will also work. So, do we really need a separate touchscreen driver? Maybe the existing one can be improved to add more features if needed?

Personally I have been looking forward to the v10 of this patchseries :) Thanks for working on this! But, yeah, we need to decide if we need this to be a separate driver.

Link: https://lore.kernel.org/all/20230326212308.55730-1-hdegoede@xxxxxxxxxx/

Regards
Joel Selvaraj