Re: [syzbot] [bluetooth?] KASAN: slab-use-after-free Write in sco_chan_del

From: syzbot
Date: Fri Aug 18 2023 - 10:06:32 EST


Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: slab-use-after-free Write in sco_chan_del

==================================================================
BUG: KASAN: slab-use-after-free in instrument_atomic_read_write include/linux/instrumented.h:96 [inline]
BUG: KASAN: slab-use-after-free in atomic_dec_and_test include/linux/atomic/atomic-instrumented.h:1375 [inline]
BUG: KASAN: slab-use-after-free in hci_conn_drop include/net/bluetooth/hci_core.h:1497 [inline]
BUG: KASAN: slab-use-after-free in sco_chan_del+0x10a/0x500 net/bluetooth/sco.c:174
Write of size 4 at addr ffff88806abb0010 by task syz-executor.4/9743

CPU: 0 PID: 9743 Comm: syz-executor.4 Not tainted 6.5.0-rc6-next-20230817-syzkaller-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106
print_address_description mm/kasan/report.c:364 [inline]
print_report+0xc4/0x620 mm/kasan/report.c:475
kasan_report+0xda/0x110 mm/kasan/report.c:588
check_region_inline mm/kasan/generic.c:181 [inline]
kasan_check_range+0xef/0x190 mm/kasan/generic.c:187
instrument_atomic_read_write include/linux/instrumented.h:96 [inline]
atomic_dec_and_test include/linux/atomic/atomic-instrumented.h:1375 [inline]
hci_conn_drop include/net/bluetooth/hci_core.h:1497 [inline]
sco_chan_del+0x10a/0x500 net/bluetooth/sco.c:174
__sco_sock_close+0xf2/0x690 net/bluetooth/sco.c:457
sco_sock_close net/bluetooth/sco.c:472 [inline]
sco_sock_release+0x6f/0x2c0 net/bluetooth/sco.c:1249
__sock_release+0xae/0x260 net/socket.c:659
sock_close+0x1c/0x20 net/socket.c:1401
__fput+0x3f7/0xac0 fs/file_table.c:384
task_work_run+0x14d/0x240 kernel/task_work.c:179
get_signal+0x106f/0x27b0 kernel/signal.c:2668
arch_do_signal_or_restart+0x90/0x7f0 arch/x86/kernel/signal.c:309
exit_to_user_mode_loop kernel/entry/common.c:168 [inline]
exit_to_user_mode_prepare+0x11f/0x240 kernel/entry/common.c:204
__syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline]
syscall_exit_to_user_mode+0x1d/0x60 kernel/entry/common.c:297
do_syscall_64+0x44/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f851807cae9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8518e2d0c8 EFLAGS: 00000246 ORIG_RAX: 000000000000002a
RAX: fffffffffffffffc RBX: 00007f851819bf80 RCX: 00007f851807cae9
RDX: 0000000000000008 RSI: 0000000020000040 RDI: 0000000000000004
RBP: 00007f85180c847a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f851819bf80 R15: 00007fff1d126688
</TASK>

Allocated by task 9661:
kasan_save_stack+0x33/0x50 mm/kasan/common.c:45
kasan_set_track+0x25/0x30 mm/kasan/common.c:52
____kasan_kmalloc mm/kasan/common.c:374 [inline]
__kasan_kmalloc+0xa2/0xb0 mm/kasan/common.c:383
kmalloc include/linux/slab.h:600 [inline]
kzalloc include/linux/slab.h:721 [inline]
hci_conn_add+0xc2/0x1770 net/bluetooth/hci_conn.c:952
hci_connect_sco+0x3ac/0xf80 net/bluetooth/hci_conn.c:1671
sco_connect net/bluetooth/sco.c:269 [inline]
sco_sock_connect+0x2c7/0xa50 net/bluetooth/sco.c:594
__sys_connect_file+0x15b/0x1a0 net/socket.c:2032
__sys_connect+0x145/0x170 net/socket.c:2049
__do_sys_connect net/socket.c:2059 [inline]
__se_sys_connect net/socket.c:2056 [inline]
__x64_sys_connect+0x72/0xb0 net/socket.c:2056
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Freed by task 5407:
kasan_save_stack+0x33/0x50 mm/kasan/common.c:45
kasan_set_track+0x25/0x30 mm/kasan/common.c:52
kasan_save_free_info+0x2b/0x40 mm/kasan/generic.c:522
____kasan_slab_free mm/kasan/common.c:236 [inline]
____kasan_slab_free+0x15e/0x1b0 mm/kasan/common.c:200
kasan_slab_free include/linux/kasan.h:164 [inline]
slab_free_hook mm/slub.c:1800 [inline]
slab_free_freelist_hook+0x114/0x1e0 mm/slub.c:1826
slab_free mm/slub.c:3809 [inline]
__kmem_cache_free+0xb8/0x2f0 mm/slub.c:3822
device_release+0xa1/0x240 drivers/base/core.c:2484
kobject_cleanup lib/kobject.c:689 [inline]
kobject_release lib/kobject.c:720 [inline]
kref_put include/linux/kref.h:65 [inline]
kobject_put+0x1f7/0x5b0 lib/kobject.c:737
put_device+0x1f/0x30 drivers/base/core.c:3731
hci_conn_unlink+0x60a/0x840 net/bluetooth/hci_conn.c:1071
hci_conn_del+0x59/0xd10 net/bluetooth/hci_conn.c:1097
hci_abort_conn_sync+0x7fc/0xb70 net/bluetooth/hci_sync.c:5417
abort_conn_sync+0x18e/0x3a0 net/bluetooth/hci_conn.c:2869
hci_cmd_sync_work+0x1a4/0x3c0 net/bluetooth/hci_sync.c:306
process_one_work+0x887/0x15d0 kernel/workqueue.c:2630
process_scheduled_works kernel/workqueue.c:2703 [inline]
worker_thread+0x8bb/0x1290 kernel/workqueue.c:2784
kthread+0x33a/0x430 kernel/kthread.c:388
ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304

Last potentially related work creation:
kasan_save_stack+0x33/0x50 mm/kasan/common.c:45
__kasan_record_aux_stack+0xbc/0xd0 mm/kasan/generic.c:492
insert_work+0x38/0x230 kernel/workqueue.c:1647
__queue_work+0x5d2/0x1060 kernel/workqueue.c:1799
__queue_delayed_work+0x1bf/0x260 kernel/workqueue.c:1950
queue_delayed_work_on+0x106/0x130 kernel/workqueue.c:1986
queue_delayed_work include/linux/workqueue.h:569 [inline]
hci_conn_drop include/net/bluetooth/hci_core.h:1523 [inline]
hci_conn_drop include/net/bluetooth/hci_core.h:1493 [inline]
sco_chan_del+0x1ff/0x500 net/bluetooth/sco.c:174
__sco_sock_close+0xf2/0x690 net/bluetooth/sco.c:457
sco_sock_close net/bluetooth/sco.c:472 [inline]
sco_sock_release+0x6f/0x2c0 net/bluetooth/sco.c:1249
__sock_release+0xae/0x260 net/socket.c:659
sock_close+0x1c/0x20 net/socket.c:1401
__fput+0x3f7/0xac0 fs/file_table.c:384
task_work_run+0x14d/0x240 kernel/task_work.c:179
get_signal+0x106f/0x27b0 kernel/signal.c:2668
arch_do_signal_or_restart+0x90/0x7f0 arch/x86/kernel/signal.c:309
exit_to_user_mode_loop kernel/entry/common.c:168 [inline]
exit_to_user_mode_prepare+0x11f/0x240 kernel/entry/common.c:204
__syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline]
syscall_exit_to_user_mode+0x1d/0x60 kernel/entry/common.c:297
do_syscall_64+0x44/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd

The buggy address belongs to the object at ffff88806abb0000
which belongs to the cache kmalloc-4k of size 4096
The buggy address is located 16 bytes inside of
freed 4096-byte region [ffff88806abb0000, ffff88806abb1000)

The buggy address belongs to the physical page:
page:ffffea0001aaec00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x6abb0
head:ffffea0001aaec00 order:3 entire_mapcount:0 nr_pages_mapped:0 pincount:0
anon flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
page_type: 0xffffffff()
raw: 00fff00000010200 ffff888012c42140 0000000000000000 dead000000000001
raw: 0000000000000000 0000000000040004 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 3, migratetype Unmovable, gfp_mask 0x1d2040(__GFP_IO|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL), pid 5425, tgid 5425 (udevd), ts 183359251571, free_ts 183195743543
set_page_owner include/linux/page_owner.h:31 [inline]
post_alloc_hook+0x2d2/0x350 mm/page_alloc.c:1550
prep_new_page mm/page_alloc.c:1557 [inline]
get_page_from_freelist+0x10d7/0x31b0 mm/page_alloc.c:3233
__alloc_pages+0x1d0/0x4a0 mm/page_alloc.c:4489
alloc_pages+0x1a9/0x270 mm/mempolicy.c:2298
alloc_slab_page mm/slub.c:1870 [inline]
allocate_slab+0x24e/0x380 mm/slub.c:2017
new_slab mm/slub.c:2070 [inline]
___slab_alloc+0x8bc/0x1570 mm/slub.c:3223
__slab_alloc.constprop.0+0x56/0xa0 mm/slub.c:3322
__slab_alloc_node mm/slub.c:3375 [inline]
slab_alloc_node mm/slub.c:3468 [inline]
__kmem_cache_alloc_node+0x137/0x350 mm/slub.c:3517
__do_kmalloc_node mm/slab_common.c:1003 [inline]
__kmalloc+0x4f/0x100 mm/slab_common.c:1017
kmalloc include/linux/slab.h:604 [inline]
tomoyo_realpath_from_path+0xb9/0x710 security/tomoyo/realpath.c:251
tomoyo_get_realpath security/tomoyo/file.c:151 [inline]
tomoyo_path_perm+0x271/0x450 security/tomoyo/file.c:822
security_inode_getattr+0xf1/0x150 security/security.c:2153
vfs_getattr fs/stat.c:206 [inline]
vfs_statx+0x180/0x430 fs/stat.c:281
vfs_fstatat+0x90/0xb0 fs/stat.c:315
__do_sys_newfstatat+0x98/0x110 fs/stat.c:485
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1150 [inline]
free_unref_page_prepare+0x479/0xa50 mm/page_alloc.c:2362
free_unref_page+0x33/0x3b0 mm/page_alloc.c:2455
__unfreeze_partials+0x21d/0x240 mm/slub.c:2655
qlink_free mm/kasan/quarantine.c:166 [inline]
qlist_free_all+0x6a/0x170 mm/kasan/quarantine.c:185
kasan_quarantine_reduce+0x18b/0x1d0 mm/kasan/quarantine.c:292
__kasan_slab_alloc+0x65/0x90 mm/kasan/common.c:305
kasan_slab_alloc include/linux/kasan.h:188 [inline]
slab_post_alloc_hook mm/slab.h:762 [inline]
slab_alloc_node mm/slub.c:3478 [inline]
slab_alloc mm/slub.c:3486 [inline]
__kmem_cache_alloc_lru mm/slub.c:3493 [inline]
kmem_cache_alloc+0x172/0x3b0 mm/slub.c:3502
getname_flags.part.0+0x50/0x4d0 fs/namei.c:140
getname_flags+0x9c/0xf0 include/linux/audit.h:319
vfs_fstatat+0x77/0xb0 fs/stat.c:314
__do_sys_newfstatat+0x98/0x110 fs/stat.c:485
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Memory state around the buggy address:
ffff88806abaff00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff88806abaff80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff88806abb0000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff88806abb0080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff88806abb0100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================


Tested on:

commit: 47762f08 Add linux-next specific files for 20230817
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
console output: https://syzkaller.appspot.com/x/log.txt?x=16a0da65a80000
kernel config: https://syzkaller.appspot.com/x/.config?x=ed03cf326b3ef94c
dashboard link: https://syzkaller.appspot.com/bug?extid=cf54c1da6574b6c1b049
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=1730dba0680000