Re: [PATCH] tty: serial: meson: Add a earlycon for the S4 SoC

[neil . armstrong]

Hi,

On 28/08/2023 14:26, Lucas Tanure wrote:
> On Mon, Aug 28, 2023 at 1:16 PM Neil Armstrong
> <neil.armstrong@xxxxxxxxxx> wrote:
> > Hi,
> >
> > On 28/08/2023 14:10, Lucas Tanure wrote:
> > > The new Amlogic S4 SoC does not have a always-on uart, so add
> > > OF_EARLYCON_DECLARE for it.
> > >
> > > Signed-off-by: Lucas Tanure <tanure@xxxxxxxxx>
> > > ---
> > >    drivers/tty/serial/meson_uart.c | 4 ++--
> > >    1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> > > index 790d910dafa5..8dfaa260e545 100644
> > > --- a/drivers/tty/serial/meson_uart.c
> > > +++ b/drivers/tty/serial/meson_uart.c
> > > @@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
> > >        return 0;
> > >    }
> > >
> > > -OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
> > > -                 meson_serial_early_console_setup);
> > > +OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
> > > +OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);
> >
> > Not sure why you would change both lines, and where's the t7 entry ?
> ok, but we don't need t7, right? T7 will use S4 compatible line.

Indeed, I forget you finally used amlogic,meson-s4-uart as fallback.

Please indicate this in the commit message.

I'll ack the revert then,

Thanks,
Neil

> > Neil
> >
> > >    #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
> > >    #else