Re: [PATCH v4] usb: typec: qcom: Update the logic of regulator enable and disable

From: Guenter Roeck
Date: Wed Aug 30 2023 - 15:23:15 EST


On 8/29/23 23:37, hui liu wrote:


On 8/30/2023 2:25 PM, Guenter Roeck wrote:
On 8/29/23 20:00, Hui Liu via B4 Relay wrote:
From: Hui Liu <quic_huliu@xxxxxxxxxxx>

Removed the call logic of disable and enable regulator
in reset function. Enable the regulator in qcom_pmic_typec_start
function and disable it in qcom_pmic_typec_stop function to
avoid unbalanced regulator disable warnings.

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Please drop.
I didn't get your mean. would you please explain it?

You kept my Reviewed-by: tag even though the current version
of the patch is completely different to the patch I reviewed.
This is inappropriate. Please drop my Reviewed-by: tag.

Guenter