Re: [PATCH V2 ethtool] hns3: add support dump registers for hns3 driver

[Jijie Shao]

on 2023/8/29 14:56, Jijie Shao wrote:
> Add support pretty printer for the registers of hns3 driver.
> This printer supports PF and VF, and is compatible with hns3
> drivers of earlier versions.
>
> Sample output:
>
> $ ethtool -d eth1
> [cmdq_regs]
>    comm_nic_csq_baseaddr_l : 0x48168000
>    comm_nic_csq_baseaddr_h : 0x00000000
>    comm_nic_csq_depth      : 0x00000080
>    comm_nic_csq_tail       : 0x00000050
>    comm_nic_csq_head       : 0x00000050
>    comm_nic_crq_baseaddr_l : 0x48170000
>    comm_nic_crq_baseaddr_h : 0x00000000
>    comm_nic_crq_depth      : 0x00000080
>    comm_nic_crq_tail       : 0x00000000
>    comm_nic_crq_head       : 0x00000000
>    comm_vector0_cmdq_src   : 0x00000000
>    comm_cmdq_intr_sts      : 0x00000000
>    comm_cmdq_intr_en       : 0x00000002
>    comm_cmdq_intr_gen      : 0x00000000
> [common_regs]
>    misc_vector_base    : 0x00000001
>    pf_other_int        : 0x00000040
>    misc_reset_sts      : 0x00000000
>    misc_vector_int_sts : 0x00000000
>    global_reset        : 0x00000000
>    fun_rst_ing         : 0x00000000
>    gro_en              : 0x00000001
> ...
>
> Signed-off-by: Jijie Shao <shaojijie@xxxxxxxxxx>
> ---
> changeLog:
>    v2: remove #pragma suggested by Michal
>    v1: https://lore.kernel.org/all/20230818085611.2483909-1-shaojijie@xxxxxxxxxx/
> ---

Hi Michal:

  This patch has been uploaded for more than 10 days and has not been merged.
  Please review this patch. and if you have any problems, please inform me in time.

 Thanks！
 Jijie Shao