drivers/pci/endpoint/functions/pci-epf-vntb.c:574:38: sparse: sparse: incorrect type in argument 2 (different address spaces)
From: kernel test robot
Date: Mon Sep 11 2023 - 21:29:08 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
commit: 0c031262d2ddfb938f9668d620d7ed674771646c PCI: endpoint: pci-epf-vntb: Fix call pci_epc_mem_free_addr() in error path
date: 10 months ago
config: i386-randconfig-063-20230912 (https://download.01.org/0day-ci/archive/20230912/202309120945.5UQE5GCL-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309120945.5UQE5GCL-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309120945.5UQE5GCL-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
drivers/pci/endpoint/functions/pci-epf-vntb.c:556:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __iomem *mw_addr @@ got void * @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:556:17: sparse: expected void [noderef] __iomem *mw_addr
drivers/pci/endpoint/functions/pci-epf-vntb.c:556:17: sparse: got void *
>> drivers/pci/endpoint/functions/pci-epf-vntb.c:574:38: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void *addr @@ got void [noderef] __iomem *mw_addr @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:574:38: sparse: expected void *addr
drivers/pci/endpoint/functions/pci-epf-vntb.c:574:38: sparse: got void [noderef] __iomem *mw_addr
drivers/pci/endpoint/functions/pci-epf-vntb.c:590:41: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void *addr @@ got void [noderef] __iomem *epf_db @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:590:41: sparse: expected void *addr
drivers/pci/endpoint/functions/pci-epf-vntb.c:590:41: sparse: got void [noderef] __iomem *epf_db
drivers/pci/endpoint/functions/pci-epf-vntb.c:1127:33: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *base @@ got struct epf_ntb_ctrl *reg @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:1127:33: sparse: expected void [noderef] __iomem *base
drivers/pci/endpoint/functions/pci-epf-vntb.c:1127:33: sparse: got struct epf_ntb_ctrl *reg
drivers/pci/endpoint/functions/pci-epf-vntb.c:1138:33: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *base @@ got struct epf_ntb_ctrl *reg @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:1138:33: sparse: expected void [noderef] __iomem *base
drivers/pci/endpoint/functions/pci-epf-vntb.c:1138:33: sparse: got struct epf_ntb_ctrl *reg
drivers/pci/endpoint/functions/pci-epf-vntb.c:1149:33: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *base @@ got struct epf_ntb_ctrl *reg @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:1149:33: sparse: expected void [noderef] __iomem *base
drivers/pci/endpoint/functions/pci-epf-vntb.c:1149:33: sparse: got struct epf_ntb_ctrl *reg
drivers/pci/endpoint/functions/pci-epf-vntb.c:1161:33: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *base @@ got struct epf_ntb_ctrl *reg @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:1161:33: sparse: expected void [noderef] __iomem *base
drivers/pci/endpoint/functions/pci-epf-vntb.c:1161:33: sparse: got struct epf_ntb_ctrl *reg
vim +574 drivers/pci/endpoint/functions/pci-epf-vntb.c
523
524 /**
525 * epf_ntb_db_bar_init() - Configure Doorbell window BARs
526 * @ntb: NTB device that facilitates communication between HOST and VHOST
527 *
528 * Returns: Zero for success, or an error code in case of failure
529 */
530 static int epf_ntb_db_bar_init(struct epf_ntb *ntb)
531 {
532 const struct pci_epc_features *epc_features;
533 u32 align;
534 struct device *dev = &ntb->epf->dev;
535 int ret;
536 struct pci_epf_bar *epf_bar;
537 void __iomem *mw_addr;
538 enum pci_barno barno;
539 size_t size = 4 * ntb->db_count;
540
541 epc_features = pci_epc_get_features(ntb->epf->epc,
542 ntb->epf->func_no,
543 ntb->epf->vfunc_no);
544 align = epc_features->align;
545
546 if (size < 128)
547 size = 128;
548
549 if (align)
550 size = ALIGN(size, align);
551 else
552 size = roundup_pow_of_two(size);
553
554 barno = ntb->epf_ntb_bar[BAR_DB];
555
> 556 mw_addr = pci_epf_alloc_space(ntb->epf, size, barno, align, 0);
557 if (!mw_addr) {
558 dev_err(dev, "Failed to allocate OB address\n");
559 return -ENOMEM;
560 }
561
562 ntb->epf_db = mw_addr;
563
564 epf_bar = &ntb->epf->bar[barno];
565
566 ret = pci_epc_set_bar(ntb->epf->epc, ntb->epf->func_no, ntb->epf->vfunc_no, epf_bar);
567 if (ret) {
568 dev_err(dev, "Doorbell BAR set failed\n");
569 goto err_alloc_peer_mem;
570 }
571 return ret;
572
573 err_alloc_peer_mem:
> 574 pci_epf_free_space(ntb->epf, mw_addr, barno, 0);
575 return -1;
576 }
577
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki