Re: [PATCH RFT 11/20] media: venus: core: Drop cache properties in resource struct
From: kernel test robot
Date: Mon Sep 11 2023 - 21:29:11 EST
Hi Konrad,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 7bc675554773f09d88101bf1ccfc8537dc7c0be9]
url: https://github.com/intel-lab-lkp/linux/commits/Konrad-Dybcio/media-venus-pm_helpers-Only-set-rate-of-the-core-clock-in-core_clks_enable/20230912-051942
base: 7bc675554773f09d88101bf1ccfc8537dc7c0be9
patch link: https://lore.kernel.org/r/20230911-topic-mars-v1-11-a7d38bf87bdb%40linaro.org
patch subject: [PATCH RFT 11/20] media: venus: core: Drop cache properties in resource struct
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230912/202309120738.fip6vVJN-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309120738.fip6vVJN-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309120738.fip6vVJN-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/media/platform/qcom/venus/hfi_venus.c: In function 'venus_isr_thread':
>> drivers/media/platform/qcom/venus/hfi_venus.c:1060:39: warning: variable 'res' set but not used [-Wunused-but-set-variable]
1060 | const struct venus_resources *res;
| ^~~
vim +/res +1060 drivers/media/platform/qcom/venus/hfi_venus.c
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1056
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1057 static irqreturn_t venus_isr_thread(struct venus_core *core)
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1058 {
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1059 struct venus_hfi_device *hdev = to_hfi_priv(core);
4cb3548a87c4a3 Stanimir Varbanov 2017-06-15 @1060 const struct venus_resources *res;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1061 void *pkt;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1062 u32 msg_ret;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1063
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1064 if (!hdev)
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1065 return IRQ_NONE;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1066
4cb3548a87c4a3 Stanimir Varbanov 2017-06-15 1067 res = hdev->core->res;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1068 pkt = hdev->pkt_buf;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1069
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1070
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1071 while (!venus_iface_msgq_read(hdev, pkt)) {
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1072 msg_ret = hfi_process_msg_packet(core, pkt);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1073 switch (msg_ret) {
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1074 case HFI_MSG_EVENT_NOTIFY:
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1075 venus_process_msg_sys_error(hdev, pkt);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1076 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1077 case HFI_MSG_SYS_INIT:
8b05e503e6c2dd Konrad Dybcio 2023-09-11 1078 /* Disable OCMEM/VMEM unconditionally until support is added */
8b05e503e6c2dd Konrad Dybcio 2023-09-11 1079 venus_hfi_core_set_resource(core, VIDC_RESOURCE_NONE,
8b05e503e6c2dd Konrad Dybcio 2023-09-11 1080 0,
8b05e503e6c2dd Konrad Dybcio 2023-09-11 1081 0,
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1082 hdev);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1083 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1084 case HFI_MSG_SYS_RELEASE_RESOURCE:
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1085 complete(&hdev->release_resource);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1086 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1087 case HFI_MSG_SYS_PC_PREP:
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1088 complete(&hdev->pwr_collapse_prep);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1089 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1090 default:
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1091 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1092 }
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1093 }
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1094
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1095 venus_flush_debug_queue(hdev);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1096
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1097 return IRQ_HANDLED;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1098 }
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1099
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki