Re: [PATCH 1/2] media: dt-bindings: mediatek: Add phandle to mediatek,scp on MDP3 RDMA

[AngeloGioacchino Del Regno]

Il 23/09/23 19:38, Krzysztof Kozlowski ha scritto:
> On 19/09/2023 11:59, AngeloGioacchino Del Regno wrote:
> > The MDP3 RDMA needs to communicate with the SCP remote processor: allow
> > specifying a phandle to a SCP core.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/media/mediatek,mdp3-rdma.yaml       | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> > index d639a1461143..0e5ce2e77e99 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> > @@ -46,6 +46,11 @@ properties:
> >         include/dt-bindings/gce/<chip>-gce.h of each chips.
> >       $ref: /schemas/types.yaml#/definitions/uint32-array
> >   
> > +  mediatek,scp:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description:
> > +      Phandle to the System Control Processor (SCP) node
>
> Why? Why do you need it? For what do you add here phandle? Your
> description should explain the purpose.

Sorry for the slow reply, just seen your feedback, thanks!
I'll add a nicer description for v2.

Cheers,
Angelo