Re: [PATCH 1/2] dt-bindings: iio: adc: ti,ads7038: Add description for ADS7038

From: Rob Herring
Date: Wed Oct 04 2023 - 11:11:56 EST


On Wed, Oct 04, 2023 at 12:23:29PM +0200, werneazc@xxxxxxxxx wrote:
> From: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
>

Needs a commit message.

> Signed-off-by: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
> ---
> .../bindings/iio/adc/ti,ads7038.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> new file mode 100644
> index 000000000000..37fbae95c8e6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ads7038.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ADS7038 and similar ADCs
> +
> +maintainers:
> + - Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
> +
> +description: |
> + Family of 7 channel, 12 bit ADCs with SPI/I2C interface.
> +
> + Datasheet: https://www.ti.com/lit/gpn/ads7038
> +
> +properties:
> + compatible:
> + enum:
> + - ti,ads7038
> + - ti,ads7138
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 60000000
> +
> + vref-supply:
> + description: Supplies the 2.5V or 5V reference voltage

I don't see that in the datasheet. It has AVDD and DVDD.

Also, looks like there are GPIOs. Those aren't ever exposed to the OS?

> +
> +required:
> + - compatible
> + - reg
> + - vref-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@0 {
> + compatible = "ti,ads7038";
> + reg = <0>;
> + vref-supply = <&refin_supply>;
> + spi-max-frequency = <10000000>;
> + };
> + };
> --
> 2.42.0
>