Re: [PATCH 2/2] iio: adc: ads7038: Add driver support for 12bit ADC
From: kernel test robot
Date: Wed Oct 04 2023 - 22:04:46 EST
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on robh/for-next linus/master v6.6-rc4 next-20231004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/werneazc-gmail-com/iio-adc-ads7038-Add-driver-support-for-12bit-ADC/20231004-182531
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20231004102330.3713-2-andre.werner%40systec-electronic.com
patch subject: [PATCH 2/2] iio: adc: ads7038: Add driver support for 12bit ADC
config: powerpc64-allyesconfig (https://download.01.org/0day-ci/archive/20231005/202310050917.qrpQA2nb-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231005/202310050917.qrpQA2nb-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310050917.qrpQA2nb-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/iio/adc/ti-ads7038-core.c:46:5: warning: no previous prototype for function 'ads7038_read_raw' [-Wmissing-prototypes]
46 | int ads7038_read_raw(struct iio_dev *indio_dev,
| ^
drivers/iio/adc/ti-ads7038-core.c:46:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
46 | int ads7038_read_raw(struct iio_dev *indio_dev,
| ^
| static
1 warning generated.
vim +/ads7038_read_raw +46 drivers/iio/adc/ti-ads7038-core.c
45
> 46 int ads7038_read_raw(struct iio_dev *indio_dev,
47 struct iio_chan_spec const *chan,
48 int *val, int *val2,
49 long mask)
50 {
51 unsigned int ret;
52 struct ads7038_ch_meas_result tmp_val;
53 struct ads7038_data *const data = (struct ads7038_data *)iio_priv(indio_dev);
54 struct ads7038_info *const info = (struct ads7038_info *)data->info;
55
56 ret = info->read_channel(indio_dev, chan->channel, &tmp_val);
57
58 if (ret < 0) {
59 dev_err(&indio_dev->dev, "Read channel returned with error %d", ret);
60 return ret;
61 }
62
63 switch (mask) {
64 case IIO_CHAN_INFO_RAW:
65 *val = tmp_val.raw;
66
67 ret = IIO_VAL_INT;
68 break;
69 case IIO_CHAN_INFO_SCALE:
70 ret = regulator_get_voltage(data->reg);
71 if (ret < 0)
72 break;
73
74 *val = ret / 1000; /* uV -> mV */
75 *val2 = (1 << chan->scan_type.realbits) - 1;
76
77 ret = IIO_VAL_FRACTIONAL;
78 break;
79 default:
80 ret = -EINVAL;
81 break;
82 }
83
84 return ret;
85 }
86
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki