Re: [PATCH v2 1/2] dt-bindings: iio: adc: ti,ads7038: Add description for ADS7038

[Krzysztof Kozlowski]

On 05/10/2023 05:54, werneazc@xxxxxxxxx wrote:
> From: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
> 
> Add basic description for ADS7x38 ADC devices. The driver does only
> support a very basic set of functionalities provided by the chip.
> Also, the example in the description covers only a setup for ADS7038 devices
> while the driver structure will support both ADS7038 (SPI) and ADS7138 (I2C) devices.
> 
> Signed-off-by: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
> ---
> - v2: Add commit message and correct vref-description copy-paste-error.
> ---
>  .../bindings/iio/adc/ti,ads7038.yaml          | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> new file mode 100644
> index 000000000000..d40869b9a604
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ads7038.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ADS7038 and similar ADCs
> +
> +maintainers:
> +  - Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
> +
> +description: |
> +  Family of 7 channel, 12 bit ADCs with SPI/I2C interface.
> +
> +  Datasheet: https://www.ti.com/lit/gpn/ads7038
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,ads7038
> +      - ti,ads7138
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    maximum: 60000000
> +
> +  vref-supply:
> +    description: Supplies the reference voltage AVDD

Didn't you already get a comment that there is no vref but avdd, so
avdd-supply?


Best regards,
Krzysztof