Re: [PATCH v6 0/3] media: i2c: Introduce driver for the TW9900 video decoder

From: Laurent Pinchart
Date: Sun Oct 08 2023 - 22:21:23 EST


On Fri, Oct 06, 2023 at 06:25:27PM +0200, Mehdi Djait wrote:
> Hello everyone,
>
> This series is based on the fifth iteration of the series introducing the
> tw9900 driver: sent 29 Dec 2020 [1]
>
> This is the version 6 of the series adding support for the Techwell
> TW9900 multi standard decoder. It's a pretty simple decoder compared to
> the TW9910, since it doesn't have a built-in scaler/crop engine.
>
> Changes v5 => v6:
> - dropped .skip_top and .field in the supported_modes
> - added error handling for the i2c writes/reads
> - added the colorimetry information to fill_fmt
> - removed pm_runtime

It's not very nice to keep the chip powered up all the time :-(

> - added the g_input_status callback
> - dropped SECAM
> - dropped the non-standard PAL/NTSC variants
>
> Any feedback is appreciated,
>
> Mehdi Djait
>
> media_tree, base-commit: 2c1bae27df787c9535e48cc27bbd11c3c3e0a235
>
> [1] https://lore.kernel.org/linux-media/20210401070802.1685823-1-maxime.chevallier@xxxxxxxxxxx/
>
> Mehdi Djait (3):
> dt-bindings: vendor-prefixes: Add techwell vendor prefix
> media: dt-bindings: media: i2c: Add bindings for TW9900
> media: i2c: Introduce a driver for the Techwell TW9900 decoder
>
> .../bindings/media/i2c/techwell,tw9900.yaml | 61 ++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> MAINTAINERS | 6 +
> drivers/media/i2c/Kconfig | 12 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/tw9900.c | 651 ++++++++++++++++++
> 6 files changed, 733 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/techwell,tw9900.yaml
> create mode 100644 drivers/media/i2c/tw9900.c

--
Regards,

Laurent Pinchart