Re: [PATCH gmem FIXUP] kvm: guestmem: do not use a file system

From: Al Viro
Date: Sun Oct 08 2023 - 22:22:54 EST


On Thu, Sep 28, 2023 at 07:22:16PM -0700, Sean Christopherson wrote:
> On Thu, 28 Sep 2023 14:06:51 -0400, Paolo Bonzini wrote:
> > Use a run-of-the-mill anonymous inode, there is nothing useful
> > being provided by kvm_gmem_fs.
> >
> >
>
> Applied to kvm-x86 guest_memfd, thanks!
>
> [1/1] kvm: guestmem: do not use a file system
> https://github.com/kvm-x86/linux/commit/0f7e60a5f42a

Please, revert; this is completely broken. anon_inode_getfile()
yields a file with the same ->f_inode every time it is called.

Again, ->f_inode of those things is shared to hell and back,
very much by design. You can't modify its ->i_op or anything
other field, for that matter. No information can be stored
in that thing - you are only allowed to use the object you've
passed via 'priv' argument.

NAKed-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>