Re: [PATCH 2/2] sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block

[Yajun Deng]

On 2023/10/9 19:26, Ingo Molnar wrote:
> * Yajun Deng <yajun.deng@xxxxxxxxx> wrote:
>
> > On 2023/10/9 18:16, Ingo Molnar wrote:
> > > * Yajun Deng <yajun.deng@xxxxxxxxx> wrote:
> > >
> > > > The member back in struct sched_rt_entity only related to RT_GROUP_SCHED,
> > > > So move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block. It
> > > > will save a few bytes.
> > > >
> > > > Also, init child when parent isn't NULL in init_tg_rt_entry().
> > > >
> > > > Signed-off-by: Yajun Deng <yajun.deng@xxxxxxxxx>
> > > > ---
> > > >    include/linux/sched.h |  2 +-
> > > >    kernel/sched/rt.c     | 18 +++++++++---------
> > > >    2 files changed, 10 insertions(+), 10 deletions(-)
> > > >
> > > > diff --git a/include/linux/sched.h b/include/linux/sched.h
> > > > index 292c31697248..d0fe56603e60 100644
> > > > --- a/include/linux/sched.h
> > > > +++ b/include/linux/sched.h
> > > > @@ -597,8 +597,8 @@ struct sched_rt_entity {
> > > >    	unsigned short			on_rq;
> > > >    	unsigned short			on_list;
> > > > -	struct sched_rt_entity		*back;
> > > >    #ifdef CONFIG_RT_GROUP_SCHED
> > > > +	struct sched_rt_entity		*back;
> > > >    	struct sched_rt_entity		*parent;
> > > >    	/* rq on which this entity is (to be) queued: */
> > > >    	struct rt_rq			*rt_rq;
> > > Title claims this change - the rest of the changes should be in a separate
> > > patch:
> >
> > Okay. I will send v2.
> It's ~v7 already by my count, isn't it?


May be. If we count from the earliest.

> Thanks,
>
> 	Ingo