Re: [PATCH] staging: wlan-ng: remove unused functions
From: Calvince Otieno
Date: Sun Oct 15 2023 - 03:55:04 EST
On Sun, Oct 15, 2023 at 10:38 AM Calvince Otieno <calvncce@xxxxxxxxx> wrote:
>
> On Fri, Oct 13, 2023 at 12:02 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> On Fri, Oct 13, 2023 at 09:52:50AM +0300, Calvince Otieno wrote:
> > The following functions were defined in the prism2mgmt.h file but neither
> > declared nor used anywhere. It is recommended that they be removed.
> >
> > - void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr,
> > struct hfa384x *priv);
> > - int prism2mgmt_set_grpaddr(u32 did,
> > u8 *prism2buf, struct p80211pstrd *pstr,
> > struct hfa384x *priv);
> > - int prism2mgmt_get_grpaddr_index(u32 did);
> >
>
> Could you look up when the functions were deleted and add that
> information to the commit message?
>
> These functions were removed five years ago in commit 123412341234
> ("delete functions").
>
> regards,
> dan carpenter
Hello Dan,
I am not able to locate exactly when these functions were deleted.
I have checked the commit history of these files prism2mgmt.h and prism2mgmt.c,
but, I can't find any commit relating to the removal of the above functions.
--
Kind regards,
Calvince Otieno