Re: [PATCH] PCI: pciehp: Prevent child devices from doing RPM on PCIe Link Down
From: kernel test robot
Date: Wed Oct 18 2023 - 21:11:14 EST
Hi Kai-Heng,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.6-rc6 next-20231017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kai-Heng-Feng/PCI-pciehp-Prevent-child-devices-from-doing-RPM-on-PCIe-Link-Down/20231017-142208
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20231016040132.23824-1-kai.heng.feng%40canonical.com
patch subject: [PATCH] PCI: pciehp: Prevent child devices from doing RPM on PCIe Link Down
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171955.hlish6FZ-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171955.hlish6FZ-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <yujie.liu@xxxxxxxxx>
| Closes: https://lore.kernel.org/r/202310171955.hlish6FZ-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/pci/hotplug/pciehp_pci.c:25:5: warning: no previous prototype for 'pci_dev_disconnect' [-Wmissing-prototypes]
25 | int pci_dev_disconnect(struct pci_dev *pdev, void *unused)
| ^~~~~~~~~~~~~~~~~~
vim +/pci_dev_disconnect +25 drivers/pci/hotplug/pciehp_pci.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 24
2bd1cb5c4e6711 Kai-Heng Feng 2023-10-16 @25 int pci_dev_disconnect(struct pci_dev *pdev, void *unused)
2bd1cb5c4e6711 Kai-Heng Feng 2023-10-16 26 {
2bd1cb5c4e6711 Kai-Heng Feng 2023-10-16 27 pm_runtime_barrier(&pdev->dev);
2bd1cb5c4e6711 Kai-Heng Feng 2023-10-16 28 pci_dev_set_disconnected(pdev, NULL);
2bd1cb5c4e6711 Kai-Heng Feng 2023-10-16 29
2bd1cb5c4e6711 Kai-Heng Feng 2023-10-16 30 return 0;
2bd1cb5c4e6711 Kai-Heng Feng 2023-10-16 31 }
2bd1cb5c4e6711 Kai-Heng Feng 2023-10-16 32
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki