RE: [PATCH v3] x86/resctrl: mba_MBps: Fall back to total b/w if local b/w unavailable

From: Luck, Tony
Date: Thu Oct 26 2023 - 18:59:45 EST


>> static void mbm_bw_count(u32 rmid, struct rmid_read *rr)
>> {
>> - struct mbm_state *m = &rr->d->mbm_local[rmid];
>> + enum resctrl_event_id mba_mbps_evt_id = pick_mba_mbps_event();
>
> How about evt_id instead of mba_mbps_evt_id? It seems pretty mouthful
> for temp variable.

Sure. The long name made sense as a globa. But as you say, a temp
variable doesn't need to be so verbose. Context from being initialized
by the pick_mba_mbps_event() function also helps reader to see what
it is used for.

I'll make that change if others vote for the v3 approach over v2.

-Tony