Re: [PATCH net] net/mlx5e: fix double free of encap_header

[Saeed Mahameed]

On 25 Oct 11:27, Dust Li wrote:
> When mlx5_packet_reformat_alloc() fails, the encap_header allocated in
> mlx5e_tc_tun_create_header_ipv4{6} will be released within it. However,
> e->encap_header is already set to the previously freed encap_header
> before mlx5_packet_reformat_alloc(). As a result, the later
> mlx5e_encap_put() will free e->encap_header again, causing a double free
> issue.
>
> mlx5e_encap_put()
>    --> mlx5e_encap_dealloc()
>        --> kfree(e->encap_header)
>
> This happens when cmd: MLX5_CMD_OP_ALLOC_PACKET_REFORMAT_CONTEXT fail.
>
> This patch fix it by not setting e->encap_header until
> mlx5_packet_reformat_alloc() success.
>
> Fixes: d589e785baf5e("net/mlx5e: Allow concurrent creation of encap entries")
> Reported-by: Cruz Zhao <cruzzhao@xxxxxxxxxxxxxxxxx>
> Reported-by: Tianchen Ding <dtcccc@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Dust Li <dust.li@xxxxxxxxxxxxxxxxx>

Applied to net-mlx5