Re: [PATCH v3 0/5] dt-bindings: interrupt-controller: Fix some loongson,liointc warnings

From: Jiaxun Yang
Date: Tue Oct 31 2023 - 06:00:18 EST




在2023年10月31日十月 上午2:36,Binbin Zhou写道:
> Hi all:
>
> Some liointc-related DTBS_CHECK warnings were found when trying to
> introduce the Loongson-2K DTS{I} for LoongArch.
> This patch series attempts to fix those warnings, as well as fixing
> non-standard property naming.
>
> Of course, these fixes also apply to MIPS Loongson-2K1000/Loongson-3A
> dts{i}.
>
> Thanks.

For the whole series:

Acked-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>

Apologize for the bad design at the first place :-(
You tried really hard to get it fixed.

Thanks
- Jiaxun

>
> -----
> V3:
> patch(1/5):
> - new patch, 'loongson,parent_int_map' renamed to 'loongson,parent-int-map';
> patch(2/5)(3/5):
> - Separate the change points into separate patches;
> patch(4/5):
> - new patch, make sure both parent map forms can be parsed;
> patch(5/5):
> - new patch, fix 'loongson,parent_int_map' references in mips loongson
> dts{i}.
>
> Link to V2:
> https://lore.kernel.org/all/20230821061315.3416836-1-zhoubinbin@xxxxxxxxxxx/
>
> V2:
> 1. Update commit message;
> 2. "interruprt-names" should be "required", the driver gets the parent
> interrupts through it;
> 3. Add more descriptions to explain the rationale for multiple nodes;
> 4. Rewrite if-else statements.
>
> Link to V1:
> https://lore.kernel.org/all/20230815084713.1627520-1-zhoubinbin@xxxxxxxxxxx/
>
> Binbin Zhou (5):
> dt-bindings: interrupt-controller: loongson,liointc: Standardize the
> naming of 'loongson,parent-int-map'
> dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check
> warning for reg-names
> dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check
> for interrupt-names
> irqchip/loongson-liointc: Fix 'loongson,parent_int_map' parse
> MIPS: Loongson64: DTS: Fix 'loongson,parent_int_map' references
>
> .../loongson,liointc.yaml | 44 +++++++++++++------
> .../boot/dts/loongson/loongson64-2k1000.dtsi | 4 +-
> .../dts/loongson/loongson64c-package.dtsi | 2 +-
> .../dts/loongson/loongson64g-package.dtsi | 2 +-
> .../dts/loongson/loongson64v_4core_virtio.dts | 2 +-
> drivers/irqchip/irq-loongson-liointc.c | 7 ++-
> 6 files changed, 41 insertions(+), 20 deletions(-)
>
> --
> 2.39.3

--
- Jiaxun