Re: [PATCH] staging: vc04_services: remove unnecessary NULL check

[Umang Jain]

Hi Dan,

Thank you for the patch.

On Tue, Oct 31, 2023 at 11:59:34AM +0300, Dan Carpenter wrote:
> We ensured that "service" as non-NULL in the previous if statement so
> there is no need to check again here.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

LGTM,

Reviewed-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>
> ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index 39b857da2d42..a0117efa2991 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -2040,8 +2040,7 @@ sync_func(void *v)
>  			continue;
>  		}
>  
> -		svc_fourcc = service ? service->base.fourcc
> -				     : VCHIQ_MAKE_FOURCC('?', '?', '?', '?');
> +		svc_fourcc = service->base.fourcc;
>  
>  		vchiq_log_trace(state->dev, VCHIQ_SYNC,
>  				"Rcvd Msg %s from %p4cc s:%d d:%d len:%d",
> -- 
> 2.42.0
>