Re: [PATCH] ARM: dts: qcom: Add LPG LED device description

From: Konrad Dybcio
Date: Wed Nov 08 2023 - 05:06:23 EST




On 11/8/23 07:59, Dmitry Baryshkov wrote:
On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay
<devnull+quic_huliu.quicinc.com@xxxxxxxxxx> wrote:

From: Hui Liu <quic_huliu@xxxxxxxxxxx>

Add LPG LED device description.

No. You are not adding "LPG LED device description". You are adding
definition for three LEDs.


Signed-off-by: Hui Liu <quic_huliu@xxxxxxxxxxx>
---
Aside from Dmitry's valid comments, the subject is wrong.

ARM points to arch/arm/ (arm32) and you're missing the name of
the file that you're modifying. Check the git log for that file
to get a grasp of it.

Konrad