Re: [PATCH 1/1] mtd: rawnand: Add deassert_wp comment

From: Boris Brezillon
Date: Fri Dec 01 2023 - 13:38:44 EST


On Fri, 1 Dec 2023 10:15:42 -0800
dregan <dregan@xxxxxxxxxxxx> wrote:

> From: Boris Brezillon <bbrezillon@xxxxxxxxxx>

I'm pretty sure I shouldn't be the author. The original patch might
have been partly written by me, but this is a fixup on top of it.

>
> Add deassert_wp description comment
>
> Signed-off-by: Boris Brezillon <bbrezillon@xxxxxxxxxx>

and you should drop my SoB too.

> Signed-off-by: David Regan <dregan@xxxxxxxxxxxx>
> ---
> include/linux/mtd/rawnand.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index fcad94aa0515..3049b05d8a20 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -1001,6 +1001,8 @@ struct nand_op_parser {
> /**
> * struct nand_operation - NAND operation descriptor
> * @cs: the CS line to select for this NAND operation
> + * @deassert_wp: set to true when the operation requires the WP pin to be
> + * de-asserted (ERASE, PROG, ...)
> * @instrs: array of instructions to execute
> * @ninstrs: length of the @instrs array
> *