Re: [PATCH v2 08/36] media: atmel: Remove useless setting of min_buffers_needed

[Hans Verkuil]

On 04/12/2023 14:22, Benjamin Gaignard wrote:
> This driver uses min_buffers_needed which vb2 uses to ensure
> start_streaming is called when at least 'min_buffers_needed'
> buffers are queued. However, this driver doesn't need this,
> it can stream fine without any buffers queued.
> Just drop this unnecessary restriction.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>
> CC: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
> CC: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
> CC: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> CC: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>
> ---
>  drivers/staging/media/deprecated/atmel/atmel-isc-base.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/media/deprecated/atmel/atmel-isc-base.c b/drivers/staging/media/deprecated/atmel/atmel-isc-base.c
> index 468568b5bb7a..c18f3ba5ae1a 100644
> --- a/drivers/staging/media/deprecated/atmel/atmel-isc-base.c
> +++ b/drivers/staging/media/deprecated/atmel/atmel-isc-base.c
> @@ -1871,7 +1871,6 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)
>  	q->mem_ops		= &vb2_dma_contig_memops;
>  	q->timestamp_flags	= V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
>  	q->lock			= &isc->lock;
> -	q->min_buffers_needed	= 1;
>  	q->dev			= isc->dev;
>  
>  	ret = vb2_queue_init(q);

This also expects one buffer to be queued on start_streaming.

So this patch can be dropped.

Regards,

	Hans