Re: [PATCH v2 11/28] binder: do unlocked work in binder_alloc_new_buf()

[Alice Ryhl]

On Mon, Dec 4, 2023 at 3:22 PM Carlos Llamas <cmllamas@xxxxxxxxxx> wrote:
> On Mon, Dec 04, 2023 at 11:57:04AM +0000, 'Alice Ryhl' via kernel-team wrote:
> > You could also write this as:
> >
> >       if (!IS_ERR(buffer)) {
> >               buffer->data_size = data_size;
> >               buffer->offsets_size = offsets_size;
> >               buffer->extra_buffers_size = extra_buffers_size;
> >       }
> >
> >       mutex_unlock(&alloc->mutex);
> >       return buffer;
>
> There is a subsequent patch that adds more work after this and makes the
> goto statement a better fit (patch 19/28)... at least IMO.

Ah, ok. SGTM!

Alice