Re: [PATCH v2 net] net: dsa: microchip: provide a list of valid protocols for xmit handler

From: Sean Nyekjaer
Date: Wed Dec 06 2023 - 12:45:35 EST


Hi Vladimir and Madhuri,

> On 6 Dec 2023, at 18.35, Vladimir Oltean <olteanv@xxxxxxxxx> wrote:
>
> On Wed, Dec 06, 2023 at 05:22:55PM +0000, Madhuri.Sripada@xxxxxxxxxxxxx wrote:
>> NULL check is missing here.

Did here what every other driver does, that uses the connect_tag_protocol() method.
(As per Vladimir’s instructions)
Not one of them, does a NULL check.

>
> Don't just leave it there, also explain why.

Message to me?

/Sean