Re: [PATCH v7 2/2] iio: pressure: driver for Honeywell HSC/SSC series

From: Jonathan Cameron
Date: Wed Dec 06 2023 - 12:46:14 EST



> > + ret = match_string(hsc_triplet_variants, HSC_VARIANTS_MAX,
> > + triplet);
> > + if (ret < 0)
> > + return dev_err_probe(dev, -EINVAL,
> > + "honeywell,pressure-triplet is invalid\n");
>
> Still you can use mentioned device property API.
>

This is one of the rare cases where basing on iio/togreg is
sensible because you do want a feature that only exists there today.
Just state that you have done so in the cover letter.

Jonathan


> ...
>
> > + return dev_err_probe(dev, -EINVAL,
> > + "pressure limits are invalid\n");
>
> Indentation?
>