Re: [PATCH 1/3] dt-bindings: power: supply: Add Acer Aspire 1 EC

[Krzysztof Kozlowski]

On 07/12/2023 12:20, Nikita Travkin wrote:
> Add binding for the EC found in the Acer Aspire 1 laptop.
> 
> Signed-off-by: Nikita Travkin <nikita@xxxxxxx>
> ---
>  .../bindings/power/supply/acer,aspire1-ec.yaml     | 73 ++++++++++++++++++++++
>  1 file changed, 73 insertions(+)
> 


> +
> +  acer,media-keys-on-top:
> +    description: Configure the keyboard layout to use media features of
> +      the fn row when the fn key is not pressed. The firmware may choose
> +      to add this property when user selects the fn mode in the firmware
> +      setup utility.
> +    type: boolean
> +
> +  connector:
> +    $ref: /schemas/connector/usb-connector.yaml#
> +
> +    properties:
> +      reg:
> +        maxItems: 1

You cannot have it... Add it to the example and see the results.

> +
> +    unevaluatedProperties: false

It should be fine to drop this as well, so you don't need anything else
than $ref.



Best regards,
Krzysztof