Re: [PATCH 2/2] interconnect: qcom: Add MSM8909 interconnect provider driver

From: kernel test robot
Date: Thu Dec 07 2023 - 11:57:46 EST


Hi Stephan,

kernel test robot noticed the following build errors:

[auto build test ERROR on feaf241ae2da2a73cb421473f52a4732128a996f]

url: https://github.com/intel-lab-lkp/linux/commits/Stephan-Gerhold/dt-bindings-interconnect-Add-Qualcomm-MSM8909-DT-bindings/20231206-223626
base: feaf241ae2da2a73cb421473f52a4732128a996f
patch link: https://lore.kernel.org/r/20231206-icc-msm8909-v1-2-fe0dd632beff%40kernkonzept.com
patch subject: [PATCH 2/2] interconnect: qcom: Add MSM8909 interconnect provider driver
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20231208/202312080018.m4nXAKLG-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231208/202312080018.m4nXAKLG-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312080018.m4nXAKLG-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/interconnect/qcom/msm8909.c:1319:12: error: incompatible function pointer types initializing 'int (*)(struct platform_device *)' with an expression of type 'void (struct platform_device *)' [-Wincompatible-function-pointer-types]
1319 | .remove = qnoc_remove,
| ^~~~~~~~~~~
1 error generated.


vim +1319 drivers/interconnect/qcom/msm8909.c

1316
1317 static struct platform_driver msm8909_noc_driver = {
1318 .probe = qnoc_probe,
> 1319 .remove = qnoc_remove,
1320 .driver = {
1321 .name = "qnoc-msm8909",
1322 .of_match_table = msm8909_noc_of_match,
1323 .sync_state = icc_sync_state,
1324 },
1325 };
1326 module_platform_driver(msm8909_noc_driver);
1327

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki