Re: [PATCH v4 net-next 5/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY
From: kernel test robot
Date: Thu Jan 11 2024 - 08:50:24 EST
Hi Dimitri,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Dimitri-Fedrau/net-phy-Add-BaseT1-auto-negotiation-constants/20240108-174130
base: net-next/main
patch link: https://lore.kernel.org/r/20240108093702.13476-6-dima.fedrau%40gmail.com
patch subject: [PATCH v4 net-next 5/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY
config: i386-randconfig-063-20240111 (https://download.01.org/0day-ci/archive/20240111/202401112120.tfRSOQJm-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240111/202401112120.tfRSOQJm-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401112120.tfRSOQJm-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> drivers/net/phy/marvell-88q2xxx.c:45:22: sparse: sparse: symbol 'mv88q222x_revb0_init_seq0' was not declared. Should it be static?
>> drivers/net/phy/marvell-88q2xxx.c:56:22: sparse: sparse: symbol 'mv88q222x_revb0_init_seq1' was not declared. Should it be static?
vim +/mv88q222x_revb0_init_seq0 +45 drivers/net/phy/marvell-88q2xxx.c
44
> 45 const struct mmd_val mv88q222x_revb0_init_seq0[] = {
46 { MDIO_MMD_PCS, 0x8033, 0x6801 },
47 { MDIO_MMD_AN, MDIO_AN_T1_CTRL, 0x0 },
48 { MDIO_MMD_PMAPMD, MDIO_CTRL1,
49 MDIO_CTRL1_LPOWER | MDIO_PMA_CTRL1_SPEED1000 },
50 { MDIO_MMD_PCS, 0xfe1b, 0x48 },
51 { MDIO_MMD_PCS, 0xffe4, 0x6b6 },
52 { MDIO_MMD_PMAPMD, MDIO_CTRL1, 0x0 },
53 { MDIO_MMD_PCS, MDIO_CTRL1, 0x0 },
54 };
55
> 56 const struct mmd_val mv88q222x_revb0_init_seq1[] = {
57 { MDIO_MMD_PCS, 0xfe79, 0x0 },
58 { MDIO_MMD_PCS, 0xfe07, 0x125a },
59 { MDIO_MMD_PCS, 0xfe09, 0x1288 },
60 { MDIO_MMD_PCS, 0xfe08, 0x2588 },
61 { MDIO_MMD_PCS, 0xfe11, 0x1105 },
62 { MDIO_MMD_PCS, 0xfe72, 0x042c },
63 { MDIO_MMD_PCS, 0xfbba, 0xcb2 },
64 { MDIO_MMD_PCS, 0xfbbb, 0xc4a },
65 { MDIO_MMD_AN, 0x8032, 0x2020 },
66 { MDIO_MMD_AN, 0x8031, 0xa28 },
67 { MDIO_MMD_AN, 0x8031, 0xc28 },
68 { MDIO_MMD_PCS, 0xffdb, 0xfc10 },
69 { MDIO_MMD_PCS, 0xfe1b, 0x58 },
70 { MDIO_MMD_PCS, 0xfe79, 0x4 },
71 { MDIO_MMD_PCS, 0xfe5f, 0xe8 },
72 { MDIO_MMD_PCS, 0xfe05, 0x755c },
73 };
74
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki