Re: [PATCH 3/6] arm64: dts: qcom: ipq5332: Add MDIO device tree

[Jie Luo]

On 1/10/2024 7:56 PM, Krzysztof Kozlowski wrote:
> On 10/01/2024 12:20, Luo Jie wrote:
> > Add the MDIO device tree of ipq5332.
>
> Subject: drop "device tree", it is obvious. Commit msg: say something
> more instead of copying the subject. Or better squash the entire patch.

Will update the commit message to improve the description when the 
series is updated.

> > Signed-off-by: Luo Jie <quic_luoj@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 44 +++++++++++++++++++++++++++
> >   1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > index bc89480820cb..e6c780e69d6e 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > @@ -214,6 +214,38 @@ serial_0_pins: serial0-state {
> >   				drive-strength = <8>;
> >   				bias-pull-up;
> >   			};
> > +
> > +			mdio0_pins: mdio0-state {
> > +				mux_0 {
>
> This wasn't tested...
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
>
> Best regards,
> Krzysztof

We will follow up the guidance mentioned in the link to validate the DTS 
patches.