Re: [PATCH net v2] net: dsa: qca8k: fix illegal usage of GPIO

[Michal Vokáč]

On 25. 01. 24 17:59, Andrew Lunn wrote:
> > diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
> > index ec57d9d52072..3663de8f2617 100644
> > --- a/drivers/net/dsa/qca/qca8k-8xxx.c
> > +++ b/drivers/net/dsa/qca/qca8k-8xxx.c
> > @@ -2037,13 +2037,11 @@ qca8k_sw_probe(struct mdio_device *mdiodev)
> >   	priv->dev = &mdiodev->dev;
> >   	priv->info = of_device_get_match_data(priv->dev);
> >   
> > -	priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset",
> > -						   GPIOD_ASIS);
> > +	priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset", GPIOD_OUT_HIGH);
>
> Sorry, i should of pointed this out on the previous version. netdev
> kept with 80 character lines. That is why what you deleted was split
> over two lines, and what you add should also split at the same point.
OK, no problem I will fix that. I did not realize, that netdev kept
that rule.

Michal