Re: [PATCH v14 2/4] Input: add core support for Goodix Berlin Touchscreen IC

From: Neil Armstrong
Date: Mon Jan 29 2024 - 04:02:53 EST


On 12/01/2024 16:08, Neil Armstrong wrote:
Hi Dmitry,

On 11/01/2024 08:20, Dmitry Torokhov wrote:
Hi Neil,

On Thu, Dec 21, 2023 at 04:21:20PM +0100, Neil Armstrong wrote:
Add initial support for the new Goodix "Berlin" touchscreen ICs.

Thank you very much for explaining how reading of additional contacts
and checksum works, it makes sense now.

I was a bit unhappy about number of times we copy/move the data over;
could you please try the patch below to see if the device still works
with it?

Sure, I'll test it and report you.

Ok it still works fine!

Sending v15 with those changes and rebased on latest linux-next.

Thanks,
Neil



I also shortened some #defines and defines some additional structures.
Also as far as I can see not everything needs to be packed as the data
is naturally aligned on the word boundaries.

Great, thank!

Neil


Thanks!