Re: [PATCH v2 1/4] ARM: dts: qcom: msm8974: Split out common part of samsung-klte

[Rong Zhang]

On Mon, 2024-01-29 at 09:22 +0100, Krzysztof Kozlowski wrote:
> On 27/01/2024 18:21, Rong Zhang wrote:
> > Samsung Galaxy S5 has many variants. Variants that support LTE use klte*
> > as their codename. Currently, the only supported one is the one without
> > any suffix, namely, klte. It is known that other klte* variants have
> > only minor differences compared to klte and can mostly work with the
> > klte DTB.
> > 
> > Split the common part into a common DTSI so that it can be imported in
> > the DTS of klte and other klte* variants.
> > 
> > Signed-off-by: Rong Zhang <i@xxxxxxxx>
> > ---
> >  .../qcom-msm8974pro-samsung-klte-common.dtsi  | 812 +++++++++++++++++
> >  .../dts/qcom/qcom-msm8974pro-samsung-klte.dts | 813 +-----------------
> >  2 files changed, 818 insertions(+), 807 deletions(-)
> 
> Why code move is not detected? It's difficult to review it. You moved
> almost 100% of lines. Please use correct -B/-M/-C arguments when
> generating patch and create new one with proper code move.

Will do in v3.

Thanks,
Rong