Re: [PATCH v6 3/4] kvm: arm64: set io memory s2 pte as normalnc for vfio pci device

From: Ankit Agrawal
Date: Fri Feb 09 2024 - 09:05:54 EST


>> + /*
>> + * To provide VM with the ability to get device IO memory
>> + * with NormalNC property, map device MMIO as NormalNC in S2.
>> + */
>
> nit: the comment doesn't provide anything of value, the logic is rather
> straightforward here.

Sure, will remove it.

>>
>> +     vfio_allow_wc = (vma->vm_flags & VM_VFIO_ALLOW_WC);
>
> Nitpick: no need for brackets, '=' has a pretty low precedence.
>
> Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>

Will change it. Thanks for the review.