Re: [PATCH] gpio: constify opaque pointer in gpio_device_find() match function
From: Andy Shevchenko
Date: Fri Feb 09 2024 - 09:07:23 EST
On Thu, Feb 08, 2024 at 09:27:04PM +0100, Krzysztof Kozlowski wrote:
> The match function used in gpio_device_find() should not modify the
> contents of passed opaque pointer, because such modification would not
> be necessary for actual matching and it could lead to quite unreadable,
> spaghetti code.
IIRC I also asked Bart about this in his series where something similar
was used.
Good it's not only me who sees the benefits from this.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko