Re: [PATCH 2/2] arm64: dts: qcom: add TP-Link Archer AX55 v1

[Krzysztof Kozlowski]

On 23/02/2024 09:17, Gabor Juhos wrote:
> Add device tree source for the TP-Link Archer AX55 v1 [1]
> which is a dual-band WiFi router based on the IPQ5018 SoC.
> 
> At the moment, only the UART, the GPIO LEDs and buttons
> are usable, but it makes it possible to boot an initramfs
> image on the device.
> 
> The device tree can be extended in the future, once support
> for other periherals will be available for the platform.
> 
> 1. https://www.tp-link.com/en/home-networking/wifi-router/archer-ax55/v1/
> 
> Signed-off-by: Gabor Juhos <j4g8y7@xxxxxxxxx>
> ---
> Note: running 'make CHECK_DTBS=y qcom/ipq5018-tplink-archer-ax55-v1.dtb'
> shows the following:
> 
>     DTC_CHK arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb
>   <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
>   	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
>   <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
>   	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
>   <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
>   	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
>   <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names:0: 'pwr_event' was expected
>   	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
>   <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
>   	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
> 
> This is not caused by the new device tree per se but comes from
> the usb@8af8800 node defined in ipq5018.dtsi. Running the check
> on 'qcom/ipq5018-rdp432-c2.dtb' shows the same.

Thanks for noticing and describing. Appreciated!

> ---
>  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
>  .../dts/qcom/ipq5018-tplink-archer-ax55-v1.dts     | 133 +++++++++++++++++++++
>  2 files changed, 134 insertions(+)

..

> +
> +		button-wps {
> +			debounce-interval = <60>;
> +			gpios = <&tlmm 31 GPIO_ACTIVE_LOW>;
> +			label = "wps";
> +			linux,code = <KEY_WPS_BUTTON>;
> +		};
> +	};
> +};
> +
> +&blsp1_uart1 {
> +	pinctrl-0 = <&uart1_pins>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +};
> +
> +&sleep_clk {
> +	clock-frequency = <32000>;
> +};
> +
> +&tlmm {
> +	button_pins: button-pins-state {
> +		pins = "gpio25", "gpio31";
> +		bias-pull-up;
> +		drive-strength = <8>;
> +		function = "gpio";

Usually we keep 'function' as second property, after 'pins', but there
is no need to send new version just for that.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof