Re: [PATCH v2] gpio: 74x164: Enable output pins after registers are reset

From: Arturas Moskvinas
Date: Thu Feb 29 2024 - 07:24:01 EST




On 2/29/24 10:54, Bartosz Golaszewski wrote:
On Thu, Feb 29, 2024 at 9:47 AM Arturas Moskvinas
<arturas.moskvinas@xxxxxxxxx> wrote:
Chip outputs are enabled[1] before actual reset is performed[2] which might
cause pin output value to flip flop if previous pin value was set to 1 in chip.
Change fixes that behavior by making sure chip is fully reset before all outputs
are enabled.

Use imperative mood in commit messages - make it: "Fix that behavior
by making sure ...".
Chip outputs are enabled[1] before actual reset is performed[2] which might
cause pin output value to flip flop if previous pin value was set to 1 in chip.
Fix that behavior by making sure chip is fully reset before all outputs are
enabled.

Bartosz, does this look better?

Arturas Moskvinas