Re: [PATCH net-next 1/4] dt-bindings: net: dsa: realtek: describe LED usage

From: Andrew Lunn
Date: Sun Mar 10 2024 - 14:52:25 EST


> + properties:
> + reg:
> + description:
> + "reg indicates the LED group for this LED"
> + enum: [0, 1, 2, 3]

Having read the code, i don't think the binding needs to say anything
about the group. It is implicit. Port LED 0 is in group 0. Port LED 1
is in group 1. So there is nothing here which is outside of the
standard LED binding. So as Linus said, i don't think you need any
YAML at all, the DSA port binding should be sufficient.

Andrew