Re: [PATCH] net: dsa: mt7530: disable LEDs before reset

From: Arınç ÜNAL
Date: Mon Mar 11 2024 - 17:23:16 EST


Why was this applied? I already explained it did not achieve anything.

Arınç

On 12.03.2024 00:10, patchwork-bot+netdevbpf@xxxxxxxxxx wrote:
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Tue, 5 Mar 2024 06:39:51 +0200 you wrote:
Disable LEDs just before resetting the MT7530 to avoid
situations where the ESW_P4_LED_0 and ESW_P3_LED_0 pin
states may cause an unintended external crystal frequency
to be selected.

The HT_XTAL_FSEL (External Crystal Frequency Selection)
field of HWTRAP (the Hardware Trap register) stores a
2-bit value that represents the state of the ESW_P4_LED_0
and ESW_P4_LED_0 pins (seemingly) sampled just after the
MT7530 has been reset, as:

[...]

Here is the summary with links:
- net: dsa: mt7530: disable LEDs before reset
https://git.kernel.org/netdev/net-next/c/2920dd92b980

You are awesome, thank you!