Re: [PATCH v3 2/2] rust: sync: add `Arc::into_unique_or_drop`
From: Boqun Feng
Date: Wed Mar 13 2024 - 14:33:06 EST
On Wed, Mar 13, 2024 at 09:50:59AM +0000, Alice Ryhl wrote:
> Boqun Feng <boqun.feng@xxxxxxxxx> writes:
> > The code looks good, and FWIW, I added the Examples section for the
> > function since I at least need something to run when queuing it to
> > rust-dev branch ;-) And I think it's overall good to have examples for
> > every `pub` function. If there is a next version (which is unlikely),
> > feel free to fold it. I can also send it alone once Miguel put your
> > patches into the rust-next branch.
>
> Thanks! If you have reviewed it, could I have your Reviewed-by tag?
>
Done.
> > From 7d26d1177a2788ba96c607fd9dc45baf469fb439 Mon Sep 17 00:00:00 2001
> > From: Boqun Feng <boqun.feng@xxxxxxxxx>
> > Date: Tue, 12 Mar 2024 10:03:39 -0700
> > Subject: [PATCH] kernel: sync: Add "Examples" section for
> > Arc::into_unique_or_drop()
> >
> > These examples provide better documentation and can serve as unit tests
> > as well, so add them.
> >
> > Signed-off-by: Boqun Feng <boqun.feng@xxxxxxxxx>
>
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
>
Thanks! I will add it.
Regards,
Boqun
> Alice