RE: [PATCH v4 3/3] arm64: dts: imx93-11x11-evk: add pca9451a support

[Joy Zou]

> -----Original Message-----
> From: Frank Li <frank.li@xxxxxxx>
> Sent: 2024年3月14日 11:44
> To: Joy Zou <joy.zou@xxxxxxx>
> Cc: Jacky Bai <ping.bai@xxxxxxx>; lgirdwood@xxxxxxxxx;
> broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 3/3] arm64: dts: imx93-11x11-evk: add pca9451a
> support
> 
> On Thu, Mar 14, 2024 at 11:29:23AM +0800, Joy Zou wrote:
> > Support pca9451a on imx93-11x11-evk.
> >
> > Signed-off-by: Joy Zou <joy.zou@xxxxxxx>
> > ---
> > Changes in v4:
> > 1. modify the comment for uSDHC but not i2c.
> >
> > Changes in v3:
> > 1. modify the voltages constraints according to the imx93 datasheet.
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 112
> ++++++++++++++++++
> >  1 file changed, 112 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 9921ea13ab48..59740dfa054c 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +
> > +	pcal6524: gpio@22 {
> > +		compatible = "nxp,pcal6524";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_pcal6524>;
> > +		reg = <0x22>;
> > +		gpio-controller;
> > +		#gpio-cells = <2>;
> > +		interrupt-controller;
> > +		#interrupt-cells = <2>;
> > +		interrupt-parent = <&gpio3>;
> > +		interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
> > +	};
> 
> It'd better order by address. gpio@22 should before pmic@25
> 
Okay, will adjust the gpio@22 location in next version.
Thanks frank!
BR
Joy Zou
> Frank
>