Re: [PATCH] staging: greybus: add comment for mutex

[Johan Hovold]

On Wed, Mar 13, 2024 at 11:51:22PM +0530, Ayush Tiwari wrote:
> This patch adds descriptive comment to mutex within the struct
> gbaudio_codec_info to clarify its intended use and to address
> checkpatch checks.
> 
> Signed-off-by: Ayush Tiwari <ayushtiw0110@xxxxxxxxx>
> ---
>  drivers/staging/greybus/audio_codec.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> index f3f7a7ec6be4..1f97d4fb16cd 100644
> --- a/drivers/staging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -71,6 +71,7 @@ struct gbaudio_codec_info {
>  	/* to maintain runtime stream params for each DAI */
>  	struct list_head dai_list;
>  	struct mutex lock;
> +	/* Lock to protect register access */
>	struct mutex register_mutex;

No, please, don't send these kind of patches.

It's one thing thing to learn how to create and send a patch upstream by
removing or adding some white space here and there to drivers in
staging, but the above is not the kind of changes that people unfamiliar
with the code in question should be adding (and the comment in this case
adds no value at all).

Johan